fix(desktop): restore meeting auto-stop fallback#5439
Open
ComputelessComputer wants to merge 2 commits into
Open
fix(desktop): restore meeting auto-stop fallback#5439ComputelessComputer wants to merge 2 commits into
ComputelessComputer wants to merge 2 commits into
Conversation
✅ Deploy Preview for old-char canceled.
|
Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.
ComputelessComputer
force-pushed
the
fix/meeting-auto-stop-trigger-fallback
branch
from
ca87089 to
a9fb137
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a9fb137. Configure here.
Keep direct trigger-stop timers from being downgraded by later helper-only micStopped events, and cover the failed mic snapshot regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop recordings when trigger apps disappear even if micStopped reports a helper process, while keeping active-trigger false positive protection.
Note
Medium Risk
Changes live STT auto-stop behavior when mic events omit trigger bundle IDs; incorrect logic could stop recordings early or leave them running after meetings end.
Overview
Meeting auto-stop now treats
micStoppedas a signal even when the stopped app list only names helper/PID processes, not the configured trigger bundle ID. A newgetAutoStopCandidateAppIdspath uses the full trigger list when no stopped app matches a trigger; confirmation still re-checks the mic and aborts if a trigger is still active.Pending auto-stop timers track whether a successful mic snapshot is required: helper-only stops need it; a prior direct trigger stop keeps the stronger path and is not downgraded by a later helper event. If that snapshot fails on the helper-only path, auto-stop is skipped.
The browser bundle-ID set is expanded and renamed (
BROWSER_AUTO_STOP_APP_IDS), covering more Chromium/Firefox variants and browsers used for calendar early-end prompts. Tests add #5436 regressions (Teams helper, Arc, Zoom helper ordering) and parameterize the early calendar prompt across multiple browsers.Reviewed by Cursor Bugbot for commit c09c2cb. Bugbot is set up for automated code reviews on this repo. Configure here.